Support actions in publishChecks Step #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
============================================
+ Coverage 86.82% 87.21% +0.38%
- Complexity 140 142 +2
============================================
Files 16 16
Lines 630 649 +19
Branches 49 49
============================================
+ Hits 547 566 +19
Misses 65 65
Partials 18 18
Continue to review full report at Codecov.
|
XiongKezhi
force-pushed
the
add-actions-in-step
branch
from
2e966f5 to
88f492a
Compare
timja
reviewed
Feb 20, 2021
src/main/java/io/jenkins/plugins/checks/steps/PublishChecksStep.java
Outdated
Show resolved
Hide resolved
XiongKezhi
force-pushed
the
add-actions-in-step
branch
from
a4f5d37 to
950ac92
Compare
|
Can you try avoid force pushing while under review please, it makes it harder for me to tell what changed so I have to review from the beginning |
timja
reviewed
Feb 21, 2021
src/main/java/io/jenkins/plugins/checks/steps/PublishChecksStep.java
Outdated
Show resolved
Hide resolved
...ces/io/jenkins/plugins/checks/steps/PublishChecksStep/StepChecksAction/help-description.html
Outdated
Show resolved
Hide resolved
...rces/io/jenkins/plugins/checks/steps/PublishChecksStep/StepChecksAction/help-identifier.html
Outdated
Show resolved
Hide resolved
src/main/resources/io/jenkins/plugins/checks/steps/PublishChecksStep/config.jelly
Outdated
Show resolved
Hide resolved
src/test/java/io/jenkins/plugins/checks/steps/PublishChecksStepITest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/jenkins/plugins/checks/steps/PublishChecksStepTest.java
Outdated
Show resolved
Hide resolved
| @@ -118,6 +118,12 @@ | |||
| <versionFormat>\d+\.\d+\.\d+</versionFormat> | |||
| <analysisConfiguration> | |||
| <revapi.ignore combine.children="append"> | |||
| <item> | |||
There was a problem hiding this comment.
is this still needed? I think you adjusted the implementation?
There was a problem hiding this comment.
no, still needed, since we still add new field to PublishChecks step.
[INFO] API problems found.
[INFO] If you're using the semver-ignore extension, update your module's version to one compatible with the current changes (e.g. mvn package revapi:update-versions). If you want to explicitly ignore these changes or provide justifications for them, add the json snippets to your Revapi configuration for the "revapi.differences" extension.
{
"code": "java.field.serialVersionUIDUnchanged",
"old": "field io.jenkins.plugins.checks.steps.PublishChecksStep.serialVersionUID",
"new": "field io.jenkins.plugins.checks.steps.PublishChecksStep.serialVersionUID",
"serialVersionUID": "1",
"justification": "ADD YOUR EXPLANATION FOR THE NECESSITY OF THIS CHANGE"
/* "package": "io.jenkins.plugins.checks.steps",
"classQualifiedName": "io.jenkins.plugins.checks.steps.PublishChecksStep",
"classSimpleName": "PublishChecksStep",
"fieldName": "serialVersionUID",
"elementKind": "field",
"oldArchive": "io.jenkins.plugins:checks-api:hpi:1.5.0",
"oldArchiveRole": "primary",
"newArchive": "io.jenkins.plugins:checks-api:hpi:1.6.0-SNAPSHOT",
"newArchiveRole": "primary",
"breaksSemanticVersioning": "true",
*/
},
Co-authored-by: Tim Jacomb <[email protected]>
Sorry, my bad 😅 |
timja
approved these changes
Feb 21, 2021
This was referenced Mar 10, 2021
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve issue: #74